ext/standard: applied fixers to improve test robustness - #23136
Open
NickSdot wants to merge 1 commit into
Open
Conversation
NickSdot
commented
Aug 8, 2026
| try { | ||
| var_dump(file_get_contents($names_arr[$i])); | ||
| } catch (\TypeError|\ValueError $e) { | ||
| echo get_class($e) . ': ' . $e->getMessage(), "\n"; |
Contributor
Author
There was a problem hiding this comment.
This (and following) save a function call; not style-only.
NickSdot
marked this pull request as ready for review
August 8, 2026 08:19
Contributor
Author
|
@bukka following your comment yesterday I reviewed this one once again, and wanted to double check.
I would make a manual follow up to get these addressed. Files affected by the style-only thematic: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asserts error class; extracted from: #22799
GitHub is lagging this, easier to review with: https://diffshub.com/php/php-src/pull/23136